Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Neos9-beta10 old NodeAggregateWasMoved cannot be normalized #5056

Closed
mhsdesign opened this issue May 16, 2024 · 1 comment · Fixed by #5070
Closed

BUG: Neos9-beta10 old NodeAggregateWasMoved cannot be normalized #5056

mhsdesign opened this issue May 16, 2024 · 1 comment · Fixed by #5070

Comments

@mhsdesign
Copy link
Member

The change #4993 caused a regression in that this event cannot be normalized:

{
  "contentStreamId": "90bcfbf8-c444-48f8-9911-ba0954ac795a",
  "nodeAggregateId": "30ef3082-e37f-4346-83cf-45ed0249381f",
  "nodeMoveMappings": [
    {
      "movedNodeOrigin": {
        "language": "pl"
      },
      "newLocations": [
        {
          "coveredDimensionSpacePoint": {
            "language": "pl"
          },
          "newSucceedingSibling": {
            "nodeAggregateId": "7db24575-1227-4c7c-87ff-7aaa98532a94",
            "originDimensionSpacePoint": {
              "language": "pl"
            },
            "parentNodeAggregateId": "6b6e1251-4346-494f-ac56-526a30a5741d",
            "parentOriginDimensionSpacePoint": {
              "language": "pl"
            }
          }
        }
      ]
    }
  ]
}

Neos\ContentRepository\Core\SharedModel\Node\NodeAggregateId::fromString(): Argument #1 ($value) must be of type string, array given, called in Neos/Neos.ContentRepository.Core/Classes/Feature/NodeMove/Event/NodeAggregateWasMoved.php on line 98

@mhsdesign
Copy link
Member Author

Note to self: We most definitely need to cover these things with tests as well, either simple unit or behat (maybe have some "old" event stream that is still supported)

Also todo improve the error which event this comes from so it says:

Failed to instantiate Domainevent for event with type "NodeAggregateWasMoved" and id "de62e850-6564-41c1-a2f2-4347816298c1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant