FEATURE: Invoke onSubmit callback on pages #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Form Pages are an instance of `AbstractSection` but their `onSubmit()` callback was never invoked by the Form Framework. Resolves: #148
daniellienert
approved these changes
Mar 29, 2022
bwaidelich
added a commit
that referenced
this pull request
Sep 13, 2022
Fixes a regression that was introduced with #149 that led to `onSubmit()` callbacks to only get hold of the form state of previous pages. With this fix `$formRuntime->getFormState()->getFormValues()` in a custom element will return the previously handled form values, even of the current form page. Fixes: #156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form Pages are an instance of
AbstractSectionbut theironSubmit()callback was never invoked by the Form Framework.
Resolves: #148