Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke onSubmit callback on pages #148

Closed
bwaidelich opened this issue Aug 6, 2021 · 0 comments · Fixed by #149
Closed

Invoke onSubmit callback on pages #148

bwaidelich opened this issue Aug 6, 2021 · 0 comments · Fixed by #149
Labels
enhancement

Comments

@bwaidelich
Copy link
Member

Even though a \Neos\Form\Core\Model\Page is an instance of \Neos\Form\Core\Model\AbstractSection (thus implementing the onSubmit() function) the callback is only invoked for form elements.

It would be very useful to have that callback on the page level, too. For example in order to post-process form values and/or tweak the form definition upon submitted values.
@bwaidelich bwaidelich added the bug label Aug 6, 2021
@bwaidelich bwaidelich self-assigned this Aug 6, 2021
@bwaidelich bwaidelich added enhancement and removed bug labels Aug 6, 2021
bwaidelich added a commit that referenced this issue Aug 6, 2021
@bwaidelich
FEATURE: Invoke onSubmit callback on pages
3be0655 
Form Pages are an instance of `AbstractSection` but their `onSubmit()`
callback was never invoked by the Form Framework.

Resolves: #148
@bwaidelich bwaidelich mentioned this issue Aug 6, 2021
Merged
@bwaidelich bwaidelich removed their assignment Aug 6, 2021
@bwaidelich bwaidelich mentioned this issue Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEATURE: Invoke onSubmit callback on pages neos/form
1 participant
@bwaidelich