Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDEV-2651 Remove syscall_stabs #279

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

s-medvedev
Copy link

  1. Use AccountStorage to access Rent sysvar and return_data()
  2. Implement log_data() and log_msg() to work with our implementation instead of syscall_stab in emulation context

@s-medvedev s-medvedev self-assigned this Feb 19, 2024
@kristinaNikolaevaa kristinaNikolaevaa added fullTestSuite Run OZ tests and part of dapps tests and removed extendedFullTestSuite labels Feb 20, 2024
@neonlabstech
Copy link

Dapps report

Cost report for "Aave" dApp

Action Fee Cost in $ Accounts TRx Estimated Gas Used Gas Used % of EG
Token mint 0.00228896 0.0029738544396128 9 1 1164480 1144480 98.28
Token approve 0.00228896 0.0029738544396128 9 1 1164480 1144480 98.28
Deposit to lending pool 0.0077856 0.010115179437408 4 5 4761840 3892800 81.75
Borrow from lending pool 0.00508792 0.0066103092585256 4 30 3737360 2543960 68.07
Repay 0.00049 0.0006366160507 4 27 2586800 245000 9.47
Flashloan 0.00501792 0.006519364108425601 4 28 7360480 2508960 34.09
Withdraw 7e-05 9.094515009999999e-05 4 5 1857760 35000 1.88
Liquidation 0.00335896 0.0043640160197128 4 57 4940000 1679480 34.0

Cost report for "Uniswap V3" dApp

Action Fee Cost in $ Accounts TRx Estimated Gas Used Gas Used % of EG
Token approve 0.00228896 0.0029738544396128 9 1 1164480 1144480 98.28
NonfungiblePositionManager - Mint position 0.02730384 0.035473597530091196 4 28 30739120 13651920 44.41
NonfungiblePositionManager - Increase liquidity 0.00044 0.0005716552292 23 23 4364240 220000 5.04
NonfungiblePositionManager - Decrease Liquidity 0.00139808 0.0018164085064543997 17 1 4274240 699040 16.35
NonfungiblePositionManager - Collect Fees 0.00455792 0.0059217245506255995 20 1 3497360 2278960 65.16
NonfungiblePositionManager - Burn Liquidity Position 2e-05 2.59843286e-05 15 1 3954560 10000 0.25
Direct swap 2e-05 2.59843286e-05 17 1 1328400 10000 0.75
Burn transaction 0.00047936 0.0006227923878848 11 1 739040 239680 32.43
Collect transaction 0.00228896 0.0029738544396128 12 1 1633840 1144480 70.05

Cost report for "Saddle Finance" dApp

Action Fee Cost in $ Accounts TRx Estimated Gas Used Gas Used % of EG
Add liquidity 0.00229896 0.0029868466039128 3 2 3181920 1149480 36.13
Swap DAI -> USDC 2e-05 2.59843286e-05 21 1 1797760 10000 0.56
Swap USDC -> DAI 2e-05 2.59843286e-05 21 1 1797760 10000 0.56
Remove liquidity 2e-05 2.59843286e-05 23 1 1937440 10000 0.52
Add liquidity in 3 Tokens 0.00278896 0.0036234626546128 4 30 4220640 1394480 33.04
Swap DAI -> USDC 3 pool 2e-05 2.59843286e-05 21 1 1807760 10000 0.55
Swap USDC -> USDT 3 pool 2e-05 2.59843286e-05 21 1 1807760 10000 0.55
Swap USDC -> DAI 3 pool 2e-05 2.59843286e-05 21 1 1807760 10000 0.55
Remove liquidity 3 pool 3e-05 3.89764929e-05 3 2 2646480 15000 0.57
Add liquidity in metapool 0.00285896 0.0037144078047127997 3 31 3271920 1429480 43.69
Swap SUSD -> LP metapool 2e-05 2.59843286e-05 22 1 1807760 10000 0.55
Swap USDC -> SUSD metapool 0.00103 0.0013381929229000001 4 53 3775520 515000 13.64
Swap DAI -> USDT metapool 0.00056 0.0007275612007999999 4 30 3086160 280000 9.07
Remove liquidity in Metapool 2e-05 2.59843286e-05 23 1 1937440 10000 0.52

@anton-lisanin anton-lisanin merged commit ce759a5 into develop Feb 20, 2024
11 of 15 checks passed
@anton-lisanin anton-lisanin deleted the NDEV-2651_remove_syscall_stabs branch February 20, 2024 12:50
anton-lisanin added a commit that referenced this pull request Feb 26, 2024
* Add Account Revision (#276)
* NDEV-2651 Remove syscall_stabs (#279)
* NDEV-2620: Add executor_state: &impl Database parameter to EventListener::event method (#273)
* add keys for Miro, DeBank/ Rabby and Alfie for devnet WL
---------

Co-authored-by: Semen Medvedev <[email protected]>
Co-authored-by: Miroslav Nedelchev <[email protected]>
Co-authored-by: Andrei Silviu Dragnea <[email protected]>
Co-authored-by: s-medvedev <[email protected]>
Co-authored-by: Kristina Nikolaeva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fullTestSuite Run OZ tests and part of dapps tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants