forked from neonevm/neon-evm
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDEV-2620: Add executor_state: &impl Database parameter to EventListener::event method #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniskore
previously approved these changes
Feb 14, 2024
stanislav-tkach
previously approved these changes
Feb 15, 2024
andreisilviudragnea
force-pushed
the
NDEV-2620
branch
from
February 16, 2024 07:17
6514e5b
to
550f606
Compare
andreisilviudragnea
dismissed stale reviews from stanislav-tkach and Deniskore
February 16, 2024 07:28
The base branch was changed.
andreisilviudragnea
requested review from
anton-lisanin,
Deniskore and
stanislav-tkach
February 16, 2024 07:28
anton-lisanin
approved these changes
Feb 16, 2024
andreisilviudragnea
added
fullTestSuite
Run OZ tests and part of dapps tests
and removed
fullTestSuite
Run OZ tests and part of dapps tests
labels
Feb 16, 2024
Dapps reportCost report for "Aave" dApp
Cost report for "Uniswap V3" dApp
Cost report for "Saddle Finance" dApp
|
anton-lisanin
added a commit
that referenced
this pull request
Feb 26, 2024
* Add Account Revision (#276) * NDEV-2651 Remove syscall_stabs (#279) * NDEV-2620: Add executor_state: &impl Database parameter to EventListener::event method (#273) * add keys for Miro, DeBank/ Rabby and Alfie for devnet WL --------- Co-authored-by: Semen Medvedev <[email protected]> Co-authored-by: Miroslav Nedelchev <[email protected]> Co-authored-by: Andrei Silviu Dragnea <[email protected]> Co-authored-by: s-medvedev <[email protected]> Co-authored-by: Kristina Nikolaeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes signature of
EventListener::event
method from:to:
Most changes in this PR come from fixing the object safety error encountered while adding this parameter:
Since
executor_state: &impl Database
is a generic type parameter, dynamic dispatch needs to be replaced with static dispatch, similar to #233.The
executor_state: &impl Database
parameter is needed to intercept state changes in tracer implementations. It is passed as an explicit parameter in order to avoid wrappingexecutor_state: &impl Database
intoRc<RefCell<>>
.