Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add a fixture for setting up neon_env and metrics server #5487

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tests: add a fixture for setting up neon_env and metrics server #5487

wants to merge 2 commits into from

Conversation

rmodpur
Copy link
Contributor

@rmodpur rmodpur commented Oct 6, 2023 •
edited by koivunej
Loading

Refactor test_pageserver_metrics_collection.py to use a custom fixture and remove duplicated code.

Fixes #5408.

@rmodpur rmodpur changed the title Add a fixture for setting up neon_env and metrics server tests: add a fixture for setting up neon_env and metrics server Oct 6, 2023
@rmodpur rmodpur force-pushed the custom-metrics-fixture branch from 4538d62 to 2073156 Compare October 6, 2023 13:50
@rmodpur
Copy link
Contributor Author

rmodpur commented Oct 6, 2023

@koivunej could you pls review

@koivunej koivunej added the approved-for-ci-run Changes are safe to trigger CI for the PR label Oct 7, 2023
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Oct 7, 2023
@vipvap vipvap mentioned this pull request Oct 7, 2023
Draft
koivunej
koivunej approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is looking great!

@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

2394 tests run: 2299 passed, 0 failed, 95 skipped (full report)

Flaky tests (2)

Postgres 15

Postgres 14

  • test_remote_storage_upload_queue_retries: debug

Code coverage (full report)

  • functions: 54.4% (9146 of 16824 functions)
  • lines: 82.0% (53256 of 64926 lines)
The comment gets automatically updated with the latest test results
b461841 at 2023-11-28T14:54:31.810Z :recycle:

@koivunej koivunej force-pushed the custom-metrics-fixture branch from 057081b to b461841 Compare November 28, 2023 13:17
@koivunej koivunej added the approved-for-ci-run Changes are safe to trigger CI for the PR label Nov 28, 2023
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koivunej koivunej koivunej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor test_pageserver_metrics_collection.py to use a custom fixture
2 participants
@rmodpur @koivunej