Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor test_pageserver_metrics_collection.py to use a custom fixture #5408

Open
koivunej opened this issue Sep 28, 2023 · 1 comment · May be fixed by #5487
Open

refactor test_pageserver_metrics_collection.py to use a custom fixture #5408

koivunej opened this issue Sep 28, 2023 · 1 comment · May be fixed by #5487
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions

Comments

@koivunej
Copy link
Member

koivunej commented Sep 28, 2023 •
edited
Loading

Now the RemoteStorageKind.NOOP has been removed there is no more extra parametrization to worry about, and the fixture can proceed to create a NeonEnv and setup common allowed errors. Point is to remove all of the duplication, and so support more test cases.

Originally posted by @koivunej in #5402 (comment)
@koivunej koivunej added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt m/good_first_issue Moment: when doing your first Neon contributions labels Sep 28, 2023
@koivunej koivunej mentioned this issue Sep 28, 2023
Merged
@rmodpur rmodpur linked a pull request Oct 6, 2023 that will close this issue
Open
@koivunej
Copy link
Member Author

Hmm the PR exists, I just have forgotten it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: add a fixture for setting up neon_env and metrics server rmodpur/neon
1 participant
@koivunej