Add AppEngine.ValidateCallFlags to be callable by subclasses #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate call flag validation into separate function so it can be called by ApplicationEngine subclasses. This is needed for the debugger, which overrides a few of the standard service implementations
shargon
approved these changes
Jul 21, 2020
|
@devhawk the code looks good, but could you add some background about why it's needed? |
|
I just realized I should have made |
This PR provides a mechanism for |
shargon
approved these changes
Jul 22, 2020
erikzhang
added a commit
that referenced
this pull request
Aug 5, 2020
* Classes related to Neo.SmartContract types should not be internal (#1785) * Classes related to Neo.SmartContract types should not be internal Fixes #1782 * public callbacks + protected internal service methods * Add AsReadOnly() Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Shargon <[email protected]> * Add AppEngine.ValidateCallFlags to be callable by subclasses (#1784) * Update ApplicationEngine.cs separate call flag validation into separate function so it can be called by ApplicationEngine subclasses. This is needed for the debugger, which overrides a few of the standard service implementations * fix whitespace * protected internal addGas Co-authored-by: Harry Pierson <[email protected]> * Fix vote (#1792) * fix vote * add ut * throw exception * fix * fix ut Co-authored-by: Tommo-L <[email protected]> Co-authored-by: erikzhang <[email protected]> * preview3 * Update dependency Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: Luchuan <[email protected]> Co-authored-by: Tommo-L <[email protected]>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Classes related to Neo.SmartContract types should not be internal (neo-project#1785) * Classes related to Neo.SmartContract types should not be internal Fixes neo-project#1782 * public callbacks + protected internal service methods * Add AsReadOnly() Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Shargon <[email protected]> * Add AppEngine.ValidateCallFlags to be callable by subclasses (neo-project#1784) * Update ApplicationEngine.cs separate call flag validation into separate function so it can be called by ApplicationEngine subclasses. This is needed for the debugger, which overrides a few of the standard service implementations * fix whitespace * protected internal addGas Co-authored-by: Harry Pierson <[email protected]> * Fix vote (neo-project#1792) * fix vote * add ut * throw exception * fix * fix ut Co-authored-by: Tommo-L <[email protected]> Co-authored-by: erikzhang <[email protected]> * preview3 * Update dependency Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: Luchuan <[email protected]> Co-authored-by: Tommo-L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.