Development version warning #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the css used for the branch on nengo-sphinx-theme with the same name.
- Moved the version warning css since the version warning is moved - Minor format change
krisfrenette
approved these changes
Aug 25, 2020
css/bootstrap.scss
Outdated
| border: 8px solid theme-color("warning"); | ||
| background-color: theme-color("warning"); | ||
| margin: auto; | ||
| text-transform: uppercase; |
There was a problem hiding this comment.
If there isn't a case where we will want this uppercase, I would suggest that we just uppercase the actual content and remove this.
There was a problem hiding this comment.
I have now removed text-transform: uppercase; and the v in the version is lowercase, but it is simpler, and looks fine.
Made text uppercase instead of using text-transform
|
Changed nengo/nengo-sphinx-theme#62 to use our existing CSS, so no longer any changes needed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the css for a similarly named nengo-sphinx-theme PR. nengo/nengo-sphinx-theme#62