Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development version warning #62

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

WAEliasmith
Copy link
Contributor

@WAEliasmith WAEliasmith commented Aug 25, 2020

This change requires css for a similarly named nengo.github.io PR. nengo/nengo.github.io#113

Small feature change.

nengo_sphinx_theme/theme/unstable_warning.html Outdated Show resolved Hide resolved
nengo_sphinx_theme/theme/unstable_warning.html Outdated Show resolved Hide resolved
nengo_sphinx_theme/theme/layout.html Outdated Show resolved Hide resolved
Copy link
Member

@drasmuss drasmuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fixup that uses our existing "admonitions" styling (which formats things in a nice looking box), which means that we don't need any CSS changes in nengo.github.io. And since the resulting code was pretty simple, I just put it right into layout.html rather than making a new file.

@drasmuss
Copy link
Member

Here's what it looks like now, for reference
Capture

@drasmuss drasmuss force-pushed the development-version-warning branch from dde0494 to fc6ac1a Compare August 25, 2020 19:12
@drasmuss
Copy link
Member

Couple more fixups so that we don't display the notification if there are no stable releases, and to ensure that the releases are sorted correctly.

@drasmuss drasmuss force-pushed the development-version-warning branch 2 times, most recently from afad76c to d523718 Compare August 25, 2020 20:48
Added a warning at the top of the screen
when accessing the current master version.
This warning is clickable to bring the user
to the latest released version.

Co-authored-by: WAEliasmith <[email protected]>
@drasmuss drasmuss force-pushed the development-version-warning branch from d523718 to 23bb11c Compare August 25, 2020 20:52
@drasmuss drasmuss merged commit 23bb11c into master Aug 25, 2020
@drasmuss drasmuss deleted the development-version-warning branch August 25, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants