Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Windows build on Bazel CI #133

Closed
drigz opened this issue Sep 23, 2019 · 2 comments
Closed

Enable Windows build on Bazel CI #133

drigz opened this issue Sep 23, 2019 · 2 comments

Comments

@drigz
Copy link
Collaborator

drigz commented Sep 23, 2019 •
edited
Loading

#132 enabled Bazel CI, but disabled the Windows build. Example failure: https://buildkite.com/bazel/rules-boost/builds/4#9c49faea-f22c-4b6b-b92d-bee0c4c088dd

There are various different errors with various libraries, so this will require quite wide-ranging changes.
drigz added a commit that referenced this issue Sep 23, 2019
@drigz
Remove reference to M_PI
fab9f7d 
It is not Standard C/C++, and affects the Windows build (#133).
@drigz
Copy link
Collaborator Author

drigz commented Sep 23, 2019 •
edited
Loading

I have been experimenting on https://github.com/nelhage/rules_boost/tree/fix-windows-ci, where I've made quite good progress, but ran into a segfault in :beast_test that I'm not sure how to debug: https://buildkite.com/bazel/rules-boost/builds/26#24efb3ae-e006-4158-b7ef-db80fb758a4a

drigz added a commit that referenced this issue Sep 25, 2019
@drigz
Remove reference to M_PI
75be023 
It is not Standard C/C++, and affects the Windows build (#133).
@nelhage
Copy link
Owner

nelhage commented Sep 25, 2019

Resolved by #134

@nelhage nelhage closed this as completed Sep 25, 2019
nbrachet pushed a commit to forgeAI/rules_boost that referenced this issue May 19, 2020
@drigz
Remove reference to M_PI
09ab02a 
It is not Standard C/C++, and affects the Windows build (nelhage#133).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelhage @drigz