-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Allow known failing actions to gracefully continue #652
Fix: Allow known failing actions to gracefully continue #652
Conversation
(cherry picked from commit 523ad07)
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=========================================
Coverage ? 49.52%
=========================================
Files ? 23
Lines ? 2328
Branches ? 0
=========================================
Hits ? 1153
Misses ? 1049
Partials ? 126
Continue to review full report at Codecov.
|
I don't think we should implement that. There is already a simple way to fix that through |
@catthehacker I suppose the env path is a good workaround but it still requires modifying the action itself to accomodate act. Further, new users are going to be confused as to why these very common functions do not work as expected, this is a less hostile approach IMHO. |
But this will break workflows for people who have it working already + https://github.com/nektos/act#skipping-steps |
@catthehacker I'm confused, how would it break them if they're already skipping the task? it would still skip it regardless as the skip check comes before the remote action check as I recall. That said for this PR to be viable there should absolutely be a force override command line switch that I should have included. |
It will break for people who are using https://github.com/anthonykawa/artifact-server |
This seems to be too much work to just workaround the problem instead of fixing it in |
Fair, just wasn't sure how far off that would be since an API has to be emulated, etc. |
Some actions such as cache, upload-artifact, and download artifact do not work due to lack of an emulated api/server.
A potential path forward exists with #169, but until that is implemented we should silently continue on some actions that would otherwise fail but do not really impact the flow of the action for testing, to allow other actions in the flow to be tested.
This is intended to be temporary until the feature is implemented.
Related: #329, #285
(cherry picked from commit 523ad07)
Output from a run against JustinGrote/Press: