Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support artifacts #169

Closed
sandorex opened this issue Mar 25, 2020 · 25 comments · Fixed by #677
Closed

Support artifacts #169

sandorex opened this issue Mar 25, 2020 · 25 comments · Fixed by #677
Labels
area/workflow Relating to workflow definitions kind/feature-request New feature or request needs-work Extra attention is needed stale-exempt Exempt from stale

Comments

@sandorex
Copy link

It would be really helpful if artifacts could be supported

@SteadBytes
Copy link

SteadBytes commented Apr 2, 2020

👍 for supporting artifacts. Or at the very least it could be helpful to produce an explicit warning/error when these actions are used. AFAICT, a step using the artifact actions will succeed but no artifact will be uploaded/downloaded.

@cplee cplee added area/workflow Relating to workflow definitions kind/feature-request New feature or request labels Apr 16, 2020
@cplee
Copy link
Contributor

cplee commented Apr 16, 2020

Great call, good feature to add. Anyone have a sample workflow to use?

@jromero
Copy link
Contributor

jromero commented May 22, 2020

This is use case we have in buildpacks/pack. We ultimately want to run test and build always and then use the artifacts for the release job.

The source can be found here:
Upload:
https://github.com/buildpacks/pack/blob/c9745af053eabf812bf2fdab1695488a01022093/.github/workflows/build.yml#L77-L81

Download:
https://github.com/buildpacks/pack/blob/c9745af053eabf812bf2fdab1695488a01022093/.github/workflows/build.yml#L92-L104

@github-actions
Copy link
Contributor

Issue is stale and will be closed in 7 days unless there is new activity

@github-actions github-actions bot added the stale label Jul 22, 2020
@zaguiini
Copy link

zaguiini commented Jul 22, 2020

Is there any progress? Can I help with something?

@cplee cplee removed the stale label Jul 22, 2020
@jromero
Copy link
Contributor

jromero commented Jul 22, 2020

Typically these artifacts are shipped via the gh API and then referenced by url.

I don't know how other parts, if any, work with mocking or intercepting GH API calls but I would think that is necessary to properly mock this locally. Am I wrong?

@krailler
Copy link

How works actions/cache? Seems similar no?

@wyTrivail
Copy link

wyTrivail commented Aug 6, 2020

we also have the same issue while using upload-artifacts, we got the error

[CI/build]   💬  ::debug::Root artifact directory is /github/workspace/build
[CI/build]   ❗  ::error::Unable to get ACTIONS_RUNTIME_TOKEN env variable
[CI/build]   ❌  Failure - Upload

it would be great if it can be mocked.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

Issue is stale and will be closed in 7 days unless there is new activity

@wagenet
Copy link

wagenet commented Oct 13, 2020

Seems like this should have remained open. It's a pretty big blocker for full use.

@cplee cplee reopened this Oct 13, 2020
@cplee cplee removed the stale label Oct 13, 2020
@ayozemr
Copy link

ayozemr commented Dec 9, 2020

Artifacts is one of those key actions that many workflows use, and bc of that its a blocker for local dev working... Having this along with cache support would make act the tool we all need to fully develop workflows locally, instead of running workflows to try things and waiting a lot of time

@github-actions
Copy link
Contributor

Issue is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added the stale label Jan 16, 2021
@ayozemr
Copy link

ayozemr commented Jan 18, 2021

Still waiting for this :-(

@github-actions github-actions bot removed the stale label Jan 19, 2021
@catthehacker
Copy link
Member

It's a bit complicated since #329

@github-actions
Copy link
Contributor

Issue is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added the stale label Feb 19, 2021
@nicolo-ribaudo
Copy link

Sorry bot, I hate to just 👍 issues

@github-actions github-actions bot removed the stale label Feb 20, 2021
@github-actions
Copy link
Contributor

Issue is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added the stale label Mar 22, 2021
@CreMindES
Copy link

Sorry bot, I hate to just +1 issues, but it's necessary in this case.

@github-actions github-actions bot removed the stale label Mar 23, 2021
@github-actions
Copy link
Contributor

Issue is stale and will be closed in 14 days unless there is new activity

@Smana
Copy link

Smana commented Jun 10, 2021

Hey, we still need a solution, either an artifact server or a mock.

@catthehacker
Copy link
Member

@Smana see #329

@volleynerd
Copy link

👍 for supporting artifacts. Or at the very least it could be helpful to produce an explicit warning/error when these actions are used. AFAICT, a step using the artifact actions will succeed but no artifact will be uploaded/downloaded.

The above is not true for me. Running 0.2.23 and seeing actions/upload-artifact fail with error ::error::Unable to get ACTIONS_RUNTIME_TOKEN env variable

Agree that this is a great idea to support the goal - for typical workflows that run fine in GH will run in ACT without modification.

@JoshMcCullough
Copy link
Contributor

JoshMcCullough commented May 16, 2023

I know this feature exists now, but I'm still getting the "unable to get ACTIONS_RUNTIME_TOKEN" error. I wonder if I'm missing something?

I set up the artifact path/port in my act call. I'm using act-js.

NM, I see this now on the related PR: --env ACTIONS_RUNTIME_TOKEN=foo must be set (we do not have authentication implemented)

@mcascone
Copy link

I know this feature exists now, but I'm still getting the "unable to get ACTIONS_RUNTIME_TOKEN" error. I wonder if I'm missing something?

I set up the artifact path/port in my act call. I'm using act-js.

NM, I see this now on the related PR: --env ACTIONS_RUNTIME_TOKEN=foo must be set (we do not have authentication implemented)

i set this, using foo (probably incorrect), and now I get:
Error: authentication required

@reducedhackers
Copy link

I know this feature exists now, but I'm still getting the "unable to get ACTIONS_RUNTIME_TOKEN" error. I wonder if I'm missing something?
I set up the artifact path/port in my act call. I'm using act-js.
NM, I see this now on the related PR: --env ACTIONS_RUNTIME_TOKEN=foo must be set (we do not have authentication implemented)

i set this, using foo (probably incorrect), and now I get: Error: authentication required

was getting the same error , discovered I can pass GitHub token into the with: element of the step , remembering to keep in mind that the token in this case is stored in a secrets file

act --secret-file ./act/act.secrets -W ./.github/workflows/deploy_dev.yml

  • name: Download Release ZIP (if URL found)
    uses: actions/download-artifact@v4 # Use dedicated download action for security
    with:
    name: somartefacts.zip
    url: ${{ steps.get_download_url.outputs.download_url }}
    repository: ${{ github.repository }}
    github-token: ${{ secrets.GITHUB_TOKEN }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflow Relating to workflow definitions kind/feature-request New feature or request needs-work Extra attention is needed stale-exempt Exempt from stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.