Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.11.0으로 업그레이드 (PR 재수정) #26

Merged
merged 273 commits into from
Dec 7, 2024
Merged

Conversation

HotoRas
Copy link

@HotoRas HotoRas commented Nov 28, 2024

What

이중 삼중으로 브랜치 따기

Why

디버깅 편의성

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests
  • (If possible) Publish docker image

kakkokari-gtyih and others added 30 commits October 3, 2024 21:01
* fix: 初期パスワードをコメントアウト

* 🎨

* fix indent
* wip

* Update MkSignin.vue

* Update MkSignin.vue

* wip

* Update CHANGELOG.md

* enhance(frontend): サインイン画面の改善

* Update Changelog

* 14655の変更取り込み

* spdx

* fix

* fix

* fix

* 🎨

* 🎨

* 🎨

* 🎨

* Captchaがリセットされない問題を修正

* 次の処理をsignin apiから読み取るように

* Add Comments

* fix

* fix test

* attempt to fix test

* fix test

* fix test

* fix test

* fix

* fix test

* fix: 一部のエラーがちゃんと出るように

* Update Changelog

* 🎨

* 🎨

* remove border

---------

Co-authored-by: syuilo <[email protected]>
* New translations ja-jp.yml (Chinese Traditional)

* New translations ja-jp.yml (Korean)

* New translations ja-jp.yml (Chinese Simplified)

* New translations ja-jp.yml (English)

* New translations ja-jp.yml (Chinese Traditional)

* New translations ja-jp.yml (Korean)

* New translations ja-jp.yml (Chinese Simplified)

* New translations ja-jp.yml (Chinese Simplified)
* fix(frontend): ログイン画面でキャプチャが表示されない問題を修正

* rename
* fix: signin の資格情報が足りないだけの場合はエラーにせず200を返すように

* run api extractor

* fix

* fix

* fix test

* /signin -> /signin-flow

* fix

* fix lint

* rename

* fix

* fix
…dev#14698)

* feat(backend): 通報および通報解決時に送出されるSystemWebhookにユーザ情報を含めるようにする

* テスト送信もペイロード形式を合わせる

* add spaces

* fix test
* wip

* Update CHANGELOG.md

* lint

* Update types.ts

* wip

* ✌️

* Update MkAbuseReport.vue

* tweak
…ev#14709)

* fix(backend/test): MisskeyIO#727 以降e2eテストがたまに失敗する問題を修正 (MisskeyIO#735)

* ✌️

---------

Co-authored-by: まっちゃとーにゅ <[email protected]>
kakkokari-gtyih and others added 12 commits November 24, 2024 09:41
* Fix type error in security fixes

(cherry picked from commit fa3cf6c2996741e642955c5e2fca8ad785e83205)

* Fix error in test function calls

(cherry picked from commit 1758f29364eca3cbd13dbb5c84909c93712b3b3b)

* Fix style error

(cherry picked from commit 23c4aa25714af145098baa7edd74c1d217e51c1a)

* Fix another style error

(cherry picked from commit 36af07abe28bec670aaebf9f5af5694bb582c29a)

* Fix `.punyHost` misuse

(cherry picked from commit 6027b516e1c82324d55d6e54d0e17cbd816feb42)

* attempt to fix test: make yaml valid

---------

Co-authored-by: Julia Johannesen <[email protected]>
* fix(backend): fix apResolver

* fix

* add comments

* tweak comment
* fix exception handling for Like activities

(cherry picked from commit 8f42e8434eaebe3aba5d1980c57f49dd8ad0de91)

* fix exception handling for Announce activities

(cherry picked from commit cfc3ab4b045af0674122fa49176431860176358b)

* fix exception handling for Undo activities

* Update Changelog

---------

Co-authored-by: Hazelnoot <[email protected]>
* New translations ja-jp.yml (Chinese Simplified)

* New translations ja-jp.yml (Chinese Simplified)
general:
- Misskey 2024.11.0으로 업그레이드

frontend:
- fix: 계정 삭제의 모더레이션 로그가 동작하지 않는 것을 수정(misskey-dev#14996)
- enhance: 비로그인 상태에서 Misskey를 열었을 때의 퍼포먼스를 향상

server:
- fix: 리노트 뮤트가 신규 투고 통지에 대해 작용하지 않았던 문제를 수정
- fix: 보안 관련 수정
- fix: Inbox 처리에서 발생하는 오류를 실수로 Activity로 처리하는 경우가 있는 문제를 수정 (Cherry-picked from https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/730)
Copy link

@Hoto-Cocoa Hoto-Cocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 받아서 라온님과 실행하고 테스트 해봤는데, 잘 동작하지만 비로그인 메인 페이지에 가입 버튼이 보여야 한다고 하시네요. 나머지 부분에는 별 문제가 없는 것 같다고 하시니 이 부분 고치고 리뷰 하고 병합하고 배포하면 될 것 같아요.

@seojangho
Copy link
Collaborator

별 문제 없을것 같지만 오늘 밤에 한번 더 테스트 돌리고 review하겠습니다

Copy link
Collaborator

@seojangho seojangho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 고생하셨습니다.

아래 사항에 대해서 머지 후 QA가 이루어지면 좋겠습니다. (제가 계획할게요)

  • 프꾸 여러개 잘 연합되는지
  • 가입이 아직 미승인된 유저가 할 수 있는 API/할 수 없는 API 확인
  • 웹소켓 끊겼을때 메시지

긴 시간 고생하셨습니다. 특히 중간중간에 타입 any인거 고친부분이라거나 등등은 잘 갈무리해서 원판 미스키에도 PR 보내볼 수 있을것 같아요.

노고에 감사드립니다.

@HotoRas
Copy link
Author

HotoRas commented Dec 7, 2024

머지하겠습니다. 고생하셨습니다.

@HotoRas HotoRas merged commit a4cf46d into neko Dec 7, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

미스키에 가입 승인제 도입