-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main
has been removed but is needed for IE 11
#727
Comments
It's true. This rules was removed for a mistake. |
The request merge is needed |
Sent from my BlackBerry 10 smartphone.
From: Gosha Egorian
Sent: Wednesday, March 14, 2018 10:23 AM
To: necolas/normalize.css
Reply To: necolas/normalize.css
Cc: Subscribed
Subject: Re: [necolas/normalize.css] `main` has been removed but is needed for IE 11 (#727)
The request merge is needed
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#727 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVnnMnBeFSprYQ6QUvZ2hAbNGE8udBHBks5teNN-gaJpZM4SCF6_>.
|
As I thought upgrade to normalize.css 8.0.0 won't break anything as out project points to user with ie >= 10, but actually this |
Old versions of IE once required a bunch of html5 elements display to be set to block. The browsers that required this are possibly out of scope, however, since the `main` element was added later, a reset is still required for this element in IE11. See: necolas#727
Woah. This is sorely needed. Just did the same thing as #730 (comment) @necolas got the time to give this some love? These two pull requests solves it: It got removed during your 8.0.0 release: 004d58b#diff-bb3dde41d97f19be8ab7b4780a915d5eL62 Not sure about IE10, but IE11 needs it. |
Please do it ! |
IE 10 needs it too. IE 9 and below need the html5shiv, iirc. |
Description ----------- While testing contao/core#8864 I noticed that the back end login of Contao 4.5 and 4.6 looks like this in IE 11: ![ie11screenshot](https://user-images.githubusercontent.com/4970961/45218806-1f59dc00-b2a9-11e8-8980-8ea4ba74d291.png) This is because Contao 4.5 started using the `<main>` element for the `#main` container. However, IE 11 treats this as an _inline_ element by default. See also necolas/normalize.css#727 I think this should probably also be added to the `reset.css` of the Contao CSS framework? https://github.com/contao-components/contao/blob/8.0.2/css/reset.css#L55-L57 ```diff -header,footer,nav,section,aside,article,figure,figcaption { +header,footer,nav,section,aside,article,figure,figcaption,main { display:block; } ``` Commits ------- 83e01d1 fix CSS for IE11 6b9f7aa Merge branch '4.6' into ie-fix
Description ----------- While testing contao/core#8864 I noticed that the back end login of Contao 4.5 and 4.6 looks like this in IE 11: ![ie11screenshot](https://user-images.githubusercontent.com/4970961/45218806-1f59dc00-b2a9-11e8-8980-8ea4ba74d291.png) This is because Contao 4.5 started using the `<main>` element for the `#main` container. However, IE 11 treats this as an _inline_ element by default. See also necolas/normalize.css#727 I think this should probably also be added to the `reset.css` of the Contao CSS framework? https://github.com/contao-components/contao/blob/8.0.2/css/reset.css#L55-L57 ```diff -header,footer,nav,section,aside,article,figure,figcaption { +header,footer,nav,section,aside,article,figure,figcaption,main { display:block; } ``` Commits ------- 83e01d11 fix CSS for IE11 6b9f7aa5 Merge branch '4.6' into ie-fix
This can be closed now since fc091cc. |
@fritx missing a publish to NPM though |
@oles yeah, I have mentioned that here: #730 (comment) |
Forgot to publish. Should be up now. Thanks |
Awesome! Thank you, @necolas! |
is needed for IE 11 to render the element properly. Probably also for IE 10.
The text was updated successfully, but these errors were encountered: