Make services private if they are only for used for DI #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
added a commit
that referenced
this pull request
Mar 2, 2015
leofeyer
pushed a commit
that referenced
this pull request
Sep 12, 2018
Description ----------- While testing contao/core#8864 I noticed that the back end login of Contao 4.5 and 4.6 looks like this in IE 11:  This is because Contao 4.5 started using the `<main>` element for the `#main` container. However, IE 11 treats this as an _inline_ element by default. See also necolas/normalize.css#727 I think this should probably also be added to the `reset.css` of the Contao CSS framework? https://github.com/contao-components/contao/blob/8.0.2/css/reset.css#L55-L57 ```diff -header,footer,nav,section,aside,article,figure,figcaption { +header,footer,nav,section,aside,article,figure,figcaption,main { display:block; } ``` Commits ------- 83e01d11 fix CSS for IE11 6b9f7aa5 Merge branch '4.6' into ie-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.