Add additional SQL condition for very low admin logic #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1333,10 +1333,13 @@ Layer: | |||
| AND admin_level = '2' | |||
| AND way_area > 9e+12 | |||
| AND ST_Within(ST_Centroid(l.way), p.way) | |||
| AND p.way && !bbox! | |||
There was a problem hiding this comment.
I was actually wrong about this line. It has a marginal impact, so I'll remove it to simplify.
pnorman
force-pushed
the
admin_planning
branch
2 times, most recently
from
d6aaed1 to
c46de5b
Compare
This helps significantly with the use of appropriate partial indexes
pnorman
force-pushed
the
admin_planning
branch
from
c46de5b to
2f2e97c
Compare
This avoids getting it wrong in cases of highly-concave regions.
pnorman
force-pushed
the
admin_planning
branch
from
837268b to
cfbeb81
Compare
nebulon42
added a commit
that referenced
this pull request
Nov 22, 2015
Add additional SQL condition for very low admin logic
|
Thanks. |
nebulon42
pushed a commit
that referenced
this pull request
Apr 22, 2018
* added rendering for shop=video games (#1) * Update amenity-points.mss * Update project.mml * Create video_games.svg * Update video_games.svg * added line breaks for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding p.way && !bbox! drastically helps query planning for some
reason. Having added !bbox! once, it needs to be added for both
tables.
osm_id < 0 doesn't change much, but would help if there was a
partial index.