Adding rendering for shop=video_games #3167
Conversation
* Update amenity-points.mss * Update project.mml * Create video_games.svg
|
Could you please find a way with a name? It allows us to make sure that there's no problem with labels. I guess you made the screenshots with Chrome, because colors seem to be odd. |
|
So, yes, name rendering also works with ways (Kingston, Jamaica, z19): |
|
The icon has two colors (cable is violet), could you fix it and make in monochromatic? |
|
Yes, that's because I used a stroke for the cable. I guess, there is no way to make a stroke without a specific colour, or is it? |
|
I don't know, but make it black then probably, like the rest,that would make it monochrome. |
|
I have this new version now, where I converted the cable into a path. Obviously, it didn't change anything on the rendering. |
project.mml
Outdated
| @@ -1481,7 +1481,7 @@ Layer: | |||
| 'mobile_phone', 'motorcycle', 'musical_instrument', 'newsagent', 'optician', 'jewelry', 'jewellery', | |||
| 'electronics', 'chemist', 'toys', 'travel_agency', 'car_parts', 'greengrocer', 'farm', 'stationery', | |||
| 'laundry', 'dry_cleaning', 'beverages', 'perfumery', 'cosmetics', 'variety_store', 'wine', 'outdoor', | |||
| 'copyshop', 'sports', 'deli', 'tobacco', 'art', 'tea', 'coffee', 'tyres', 'pastry', 'chocolate', 'music', 'medical_supply', 'dairy') THEN shop | |||
| 'copyshop', 'sports', 'deli', 'tobacco', 'art', 'tea', 'coffee', 'tyres', 'pastry', 'chocolate', 'music', 'medical_supply', 'dairy', 'video_games') THEN shop | |||
There was a problem hiding this comment.
I would like to have some line breaks to make shop list more readable, probably before 'music'.
project.mml
Outdated
| @@ -1597,7 +1597,7 @@ Layer: | |||
| 'mobile_phone', 'motorcycle', 'musical_instrument', 'newsagent', 'optician', 'jewelry', 'jewellery', | |||
| 'electronics', 'chemist', 'toys', 'travel_agency', 'car_parts', 'greengrocer', 'farm', 'stationery', | |||
| 'laundry', 'dry_cleaning', 'beverages', 'perfumery', 'cosmetics', 'variety_store', 'wine', 'outdoor', | |||
| 'copyshop', 'sports', 'deli', 'tobacco', 'art', 'tea', 'coffee', 'tyres', 'pastry', 'chocolate', 'music', 'medical_supply', 'dairy') THEN shop | |||
| 'copyshop', 'sports', 'deli', 'tobacco', 'art', 'tea', 'coffee', 'tyres', 'pastry', 'chocolate', 'music', 'medical_supply', 'dairy', 'video_games') THEN shop | |||
There was a problem hiding this comment.
I'd like to have a line break here too.
|
Do you think you can make the final changes soon? |
|
Should be fine now |
|
Great, thanks a lot! |
Fixes #3117
Changes proposed in this pull request:
Test rendering with links to the example places:
Way z17 in Orange Walk Town (has no name):
z18:
Node z17 in East Greenwich:
z18: