Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JupyterHub 5.0.0b2 #2468

Merged
merged 2 commits into from
May 23, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 16, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): version update

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

For reference the helm chart - JupyterHub version mapping is available at https://hub.jupyter.org/helm-chart/

@krassowski
Copy link
Member Author

The failure is unrelated, it comes from the vscode button being elsewhere now that we use jupyterlab-new-launcher:

image

I will open a PR to fix this.

As for JupyterHub upgrade, I wonder if styling of top navigation bar is off. I think it was not like this before, but I need to check:

image

@viniciusdc
Copy link
Contributor

@krassowski can you rerun the tests with the latest changes? just want to make sure we catch any other playwright errors if they do appear with this new bump

@marcelovilla marcelovilla merged commit 11717f9 into nebari-dev:develop May 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants