Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title missing for code-server and console tiles #32

Closed
krassowski opened this issue May 17, 2024 · 0 comments · Fixed by #33
Closed

Title missing for code-server and console tiles #32

krassowski opened this issue May 17, 2024 · 0 comments · Fixed by #33
Labels

Comments

@krassowski
Copy link
Member

The title is empty for vscode and console tiles and the former causes nebari tests to fail (nebari-dev/nebari#2468 (comment)):

image

This is implemented here:

https://github.com/nebari-dev/jupyterlab-new-launcher/blob/dbf5f857a6bf4ae88a3c4873ac5014a67e95c834/src/components/card.tsx#L17

Upstream falls back to label if caption is not available. We should too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant