Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract-distribution): Replace ChunkContractDeployments with new message for sending code partially #12346

Merged
merged 35 commits into from
Oct 30, 2024

Conversation

tayfunelmas
Copy link
Contributor

This is on top of #12340, thus it is missing some code from the other PR. This implements the plumbing of the new message through network and testloop stacks.

@tayfunelmas tayfunelmas marked this pull request as ready for review October 30, 2024 14:00
@tayfunelmas tayfunelmas requested a review from a team as a code owner October 30, 2024 14:00
Copy link
Contributor

@pugachAG pugachAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the comments, otherwise looks good, thanks!

chain/network/src/state_witness.rs Outdated Show resolved Hide resolved
chain/network/src/types.rs Outdated Show resolved Hide resolved
@tayfunelmas tayfunelmas added this pull request to the merge queue Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (7336e0a) to head (1d77a2d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
chain/network/src/test_loop.rs 0.00% 10 Missing ⚠️
chain/client/src/test_utils/setup.rs 0.00% 8 Missing ⚠️
.../src/stateless_validation/contract_distribution.rs 0.00% 4 Missing ⚠️
...alidation/partial_witness/partial_witness_actor.rs 0.00% 3 Missing ⚠️
...hain/network/src/peer_manager/network_state/mod.rs 0.00% 3 Missing ⚠️
chain/network/src/network_protocol/mod.rs 0.00% 2 Missing ⚠️
chain/network/src/rate_limits/messages_limits.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12346      +/-   ##
==========================================
+ Coverage   71.17%   71.18%   +0.01%     
==========================================
  Files         839      839              
  Lines      169791   169743      -48     
  Branches   169791   169743      -48     
==========================================
- Hits       120845   120830      -15     
+ Misses      43688    43655      -33     
  Partials     5258     5258              
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (?)
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.22% <0.00%> (+<0.01%) ⬆️
integration-tests 38.99% <0.00%> (+<0.01%) ⬆️
linux 70.64% <0.00%> (+0.02%) ⬆️
linux-nightly 70.76% <0.00%> (+0.02%) ⬆️
macos 50.42% <0.00%> (+<0.01%) ⬆️
pytests 1.54% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.34% <0.00%> (+<0.01%) ⬆️
unittests 64.15% <0.00%> (+0.01%) ⬆️
upgradability 0.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit 7a7f3ea Oct 30, 2024
26 of 29 checks passed
@tayfunelmas tayfunelmas deleted the contract-dist-deploy2 branch October 30, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants