Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distribution of partial encoded contract deploys #12340

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented Oct 30, 2024

This does not including networking, validation and metrics. Those will be added in the followup PRs.

@pugachAG pugachAG force-pushed the witness-reed-solomon-refactor branch 5 times, most recently from 6878e62 to 2f2149d Compare October 30, 2024 11:44
@pugachAG pugachAG marked this pull request as ready for review October 30, 2024 12:20
@pugachAG pugachAG requested a review from a team as a code owner October 30, 2024 12:20
@pugachAG pugachAG requested review from wacban and tayfunelmas and removed request for a team and wacban October 30, 2024 12:20
@pugachAG pugachAG force-pushed the witness-reed-solomon-refactor branch from 2f2149d to 9903b4b Compare October 30, 2024 12:40
@pugachAG pugachAG force-pushed the partial-contract-deploys-core branch from f6ae1f3 to afb36f1 Compare October 30, 2024 13:06
Base automatically changed from witness-reed-solomon-refactor to master October 30, 2024 13:24
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 2.83401% with 240 lines in your changes missing coverage. Please review.

Project coverage is 71.15%. Comparing base (4c23860) to head (22629fd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...alidation/partial_witness/partial_witness_actor.rs 4.04% 95 Missing ⚠️
.../src/stateless_validation/contract_distribution.rs 0.00% 59 Missing ⚠️
...idation/partial_witness/partial_deploys_tracker.rs 5.08% 56 Missing ⚠️
core/primitives/src/validator_signer.rs 0.00% 21 Missing ⚠️
chain/client/src/stateless_validation/validate.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12340      +/-   ##
==========================================
+ Coverage   70.88%   71.15%   +0.26%     
==========================================
  Files         838      839       +1     
  Lines      169481   169728     +247     
  Branches   169481   169728     +247     
==========================================
+ Hits       120145   120777     +632     
+ Misses      44117    43691     -426     
- Partials     5219     5260      +41     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (-0.01%) ⬇️
genesis-check 1.22% <0.00%> (-0.01%) ⬇️
integration-tests 38.99% <2.83%> (+0.85%) ⬆️
linux 70.61% <2.83%> (-0.11%) ⬇️
linux-nightly 70.74% <2.83%> (+6.94%) ⬆️
macos 50.30% <2.83%> (-0.10%) ⬇️
pytests 1.53% <0.00%> (-0.01%) ⬇️
sanity-checks 1.34% <0.00%> (-0.01%) ⬇️
unittests 64.08% <2.83%> (-0.11%) ⬇️
upgradability 0.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pugachAG pugachAG force-pushed the partial-contract-deploys-core branch from afb36f1 to d82d8da Compare October 30, 2024 13:40
@pugachAG pugachAG added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 9c06b22 Oct 30, 2024
26 of 29 checks passed
@pugachAG pugachAG deleted the partial-contract-deploys-core branch October 30, 2024 14:29
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2024
…w message for sending code partially (#12346)

This is on top of #12340, thus it
is missing some code from the other PR. This implements the plumbing of
the new message through network and testloop stacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants