Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve congestion control nayduck test #12319

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat: improve congestion control nayduck test #12319

merged 2 commits into from
Oct 28, 2024

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Oct 25, 2024

Added a fail fast check at the beginning to the test and a nice comment explaining the most common reason - the test contract built without the test_features enabled.

This addresses the first part of #12305

@wacban wacban requested a review from a team as a code owner October 25, 2024 14:34
Copy link
Contributor

@jancionear jancionear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

pytest/tests/sanity/congestion_control.py Outdated Show resolved Hide resolved
@wacban wacban enabled auto-merge October 28, 2024 12:49
@wacban wacban added this pull request to the merge queue Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.24%. Comparing base (d0f156d) to head (f429379).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12319      +/-   ##
==========================================
- Coverage   71.56%   71.24%   -0.33%     
==========================================
  Files         838      838              
  Lines      168683   169020     +337     
  Branches   168683   169020     +337     
==========================================
- Hits       120713   120410     -303     
- Misses      42712    43363     +651     
+ Partials     5258     5247      -11     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (-0.01%) ⬇️
db-migration 0.16% <ø> (-0.01%) ⬇️
genesis-check 1.23% <ø> (-0.01%) ⬇️
integration-tests 39.07% <ø> (+0.13%) ⬆️
linux 70.69% <ø> (-0.40%) ⬇️
linux-nightly 70.82% <ø> (-0.31%) ⬇️
macos 50.32% <ø> (-3.86%) ⬇️
pytests 1.54% <ø> (-0.01%) ⬇️
sanity-checks 1.35% <ø> (-0.01%) ⬇️
unittests 64.13% <ø> (-1.20%) ⬇️
upgradability 0.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into master with commit 8d2645e Oct 28, 2024
28 of 29 checks passed
@wacban wacban deleted the waclaw-nayduck branch October 28, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants