-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with the congestion_control.py test #12305
Comments
Thanks, it's probably caused by relaxing the congestion control parameters recently. I'll have a look. |
Not sure if related but the test contracts should be built with |
I should probably add that it passes on my personal machine |
Yeah, I can confirm the test fails with the following error when the test contracts are built without test_features. It's kind of annoying so I'll see if I can detect it and fail fast.
|
With test_features enabled I don't get the first error, but I still get the rejected count equal to zero error sometimes.
(Tested on gcp VM) |
Added a fail fast check at the beginning to the test and a nice comment explaining the most common reason - the test contract built without the test_features enabled. This addresses the first part of #12305
yeah, I have an idea on how to improve it but I need to code it. I think the bottleneck is the lone node that is taking in all the transactions. I hope that by adding more nodes I can make the chain process more transactions and get congested more reliably. |
Fixed in #12331 |
Description
The
pytest/tests/sanity/congestion_control.py
test seems to be flaky.It failed in my nayduck run, so I tried to run it locally, but I can't even get it to pass on master (b27295b).
I did a test on
n2d-standard8
GCP VM:I ran the test three times and each time it failed with:
In my nayduck run It failed with a different error:
The text was updated successfully, but these errors were encountered: