-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epoch Sync] Change EpochSyncRequest/Response to direct network messages #12236
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12236 +/- ##
==========================================
- Coverage 71.68% 71.67% -0.02%
==========================================
Files 836 836
Lines 167138 167176 +38
Branches 167138 167176 +38
==========================================
+ Hits 119815 119817 +2
- Misses 42095 42129 +34
- Partials 5228 5230 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -446,4 +459,17 @@ mod tests { | |||
}}); | |||
assert!(serde_json::from_value::<OverrideConfig>(json).is_err()); | |||
} | |||
|
|||
#[test] | |||
fn test_epoch_sync_rate_limit() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
It was previously a mistake to use routed messages. There's no reason to do that.
This also applies rate limiting to the network messages.
Closes #11937
Closes #12091