[Epoch Sync] Change EpochSyncRequest/Response to direct network messages #12236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12236 +/- ##
==========================================
- Coverage 71.68% 71.67% -0.02%
==========================================
Files 836 836
Lines 167138 167176 +38
Branches 167138 167176 +38
==========================================
+ Hits 119815 119817 +2
- Misses 42095 42129 +34
- Partials 5228 5230 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saketh-are
approved these changes
Oct 17, 2024
| @@ -446,4 +459,17 @@ mod tests { | |||
| }}); | |||
| assert!(serde_json::from_value::<OverrideConfig>(json).is_err()); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_epoch_sync_rate_limit() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously a mistake to use routed messages. There's no reason to do that.
This also applies rate limiting to the network messages.
Closes #11937
Closes #12091