Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epoch Sync] Implement network rate limiting and caching for EpochSyncRequest #11937

Closed
Tracked by #73
robin-near opened this issue Aug 14, 2024 · 0 comments · Fixed by #12236
Closed
Tracked by #73

[Epoch Sync] Implement network rate limiting and caching for EpochSyncRequest #11937

robin-near opened this issue Aug 14, 2024 · 0 comments · Fixed by #12236

Comments

@robin-near
Copy link
Contributor

The request is very heavy so we need to rate limit it heavily (say, 1 minute per peer), and cache the response because it only changes once per epoch.
@robin-near robin-near mentioned this issue Aug 14, 2024
Open
@github-actions github-actions bot mentioned this issue Sep 1, 2024
Open
@robin-near robin-near mentioned this issue Oct 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2024
@robin-near
[Epoch Sync] Change EpochSyncRequest/Response to direct network messa…
7ce9e95 
…ges (#12236)

It was previously a mistake to use routed messages. There's no reason to
do that.

This also applies rate limiting to the network messages.

Closes #11937 
Closes #12091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Epoch Sync] Change EpochSyncRequest/Response to direct network messages robin-near/nearcore
1 participant
@robin-near