refactor: restrict ChainUpdate fields visibility #10388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
force-pushed
the
refactor-chain-update
branch
from
16aa155 to
66682e0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10388 +/- ##
==========================================
+ Coverage 71.99% 72.02% +0.02%
==========================================
Files 718 718
Lines 144524 144520 -4
Branches 144524 144520 -4
==========================================
+ Hits 104050 104089 +39
+ Misses 35722 35686 -36
+ Partials 4752 4745 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| let mut store_update = chain_update.chain_store_update.store().store_update(); | ||
| let epoch_manager = self.epoch_manager.clone(); | ||
| let mut chain_store_update = self.store.store_update(); | ||
| let mut store_update = store.store_update(); |
There was a problem hiding this comment.
Aah this is super confusing. store can be ChainStore or Store depending on whether it comes from self.store or not.
There was a problem hiding this comment.
In the future we might want to rename all references to store of type ChainStore to chain_store maybe?
There was a problem hiding this comment.
yeah, I agree, chain_store would be better
shreyan-gupta
approved these changes
Jan 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Follow up from PR #10388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
pub(crate)fromChainUpdatefields. All usage is refactored to directly useChain's fields.This is a follow-up for #10380.