refactor: move ChainUpdate to a separate file #10380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
force-pushed
the
split-chain-update
branch
from
f331cef to
cd24413
Compare
pugachAG
force-pushed
the
split-chain-update
branch
from
cd24413 to
9da3955
Compare
pugachAG
force-pushed
the
split-chain-update
branch
from
9da3955 to
70e1f84
Compare
pugachAG
force-pushed
the
split-chain-update
branch
from
70e1f84 to
4c373d3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10380 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 717 718 +1
Lines 144521 144524 +3
Branches 144521 144524 +3
=======================================
+ Hits 104072 104083 +11
+ Misses 35697 35687 -10
- Partials 4752 4754 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shreyan-gupta
approved these changes
Jan 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Removes `pub(crate)` from `ChainUpdate` fields. All usage is refactored to directly use `Chain`'s fields. This is a follow-up for #10380.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
ChainUpdateto its own module as it is without any additional refactoring and making all currently used fields and methodpub(crate). I'm planning to fix that in a separate PR to make it easier to review.Part of #10275.