add key_version to sign call #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
commented
Apr 3, 2024
|
Thanks for this! My understanding is that, for now, there is only one key version. Since we are currently completely reworking the key management system, would it be workable to just... hardcode the key version in the MPC contract |
Yea that would make the changes here much less invasive. Also what do you think about me splitting the PR into:
|
|
Ok, so I hard coded the |
bh2smith
force-pushed
the
3/add-key-version
branch
from
06318c0 to
75414cd
Compare
bh2smith
force-pushed
the
3/add-key-version
branch
from
75414cd to
46bd0cf
Compare
|
I split the PR into two. The test fixing should be merged first so I can baser this on there and test the real changes. |
bh2smith
force-pushed
the
3/add-key-version
branch
from
3c72a0d to
76af6bb
Compare
bh2smith
force-pushed
the
3/add-key-version
branch
from
76af6bb to
5c539c6
Compare
encody
approved these changes
Apr 4, 2024
|
Looks awesome, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If approved, this PR closes #3.
The
key_versionfield was made mandatory on the MPC-recovery contract (cf near/mpc#509). So now this contract needs to pass along key version.It was suggested to simply hard code the value in the call-site, but we also had to update function signatures.Note that we also fixed some unrelated broken tests and the changes have been made of two commits (for easier reviewing).
I would also be willing to add a CI file to this project (in a follow up PR)
cc @encody