Make the key version mandatory #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll update key versions when we increase the security of our system, or periodically lower the amount of assets accessible to former validator cohorts. New key versions mean new keys. Previously this field was optional, but if we leave it optional we have to make a decision to either interpret None as 0, the least secure key version, or continually update it to the latest one, changing peoples keys from under them. Since there isn't a good answer I feel it's better to make them mandatory, so people at least have to think about them a bit.
|
Up to you guys if you want to merge this or not, it's your codebase. Proximity is fine with it if it lands today, otherwise we can punt it until post launch. |
volovyks
previously approved these changes
Mar 21, 2024
volovyks
approved these changes
Mar 21, 2024
|
@ppca Once we release a new version, let's post in a chat that the key version is now mandatory |
Terraform Feature Environment Destroy (dev-509)Terraform Initialization ⚙️
|
|
@volovyks the contract is not initialized yet, do we want to directly include this in the testnet launch? |
|
I think so, I'd imagine that the nodes are running the version expecting this field? |
|
@ppca once we have N (probably 8 nodes) we can test the automatic deployment of the new Docker image with this and other changes. We can init the contract after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll update key versions when we increase the security of our system, or periodically lower the amount of assets accessible to former validator cohorts. New key versions mean new keys.
Previously this field was optional, but if we leave it optional we have to make a decision to either interpret None as 0, the least secure key version, or continually update it to the latest one, changing peoples keys from under them.
Since there isn't a good answer I feel it's better to make them mandatory, so people at least have to think about them a bit.