Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display user first/last name in breakout room participants selector #562

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Display user first/last name in breakout room participants selector #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4fdf32
Display user first/last name in breakout room participants selector
armccoy Jan 11, 2024
3a362ff
breakout rooms: use fullname(); fix JSON trailing comma
jrchamp Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mod_form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,10 @@ public function definition() {
// Getting Course participants.
$courseparticipants = [];
foreach ($participants as $participant) {
$courseparticipants[] = ['participantid' => $participant->id, 'participantemail' => $participant->email];
$courseparticipants[] = [
'participantid' => $participant->id,
'participantname' => fullname($participant) . ' <' . $participant->email . '>',
];
}

// Getting Course groups.
Expand Down
2 changes: 1 addition & 1 deletion templates/breakoutrooms_room_data.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"courseparticipants": [
{
"participantid": "2",
"participantemail": "[email protected]",
"participantname": "John Doe",
"selected": true
}
],
Expand Down
2 changes: 1 addition & 1 deletion templates/breakoutrooms_room_datatoclone.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"courseparticipants": [
{
"participantid": "2",
"participantemail": "[email protected]",
"participantname": "John Doe",
"selected": true
}
],
Expand Down
4 changes: 2 additions & 2 deletions templates/breakoutrooms_room_participants.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"courseparticipants": [
{
"participantid": "2",
"participantemail": "[email protected]",
"participantname": "John Doe",
"selected": true
}
]
Expand All @@ -39,7 +39,7 @@
<div class="card-body">
<select id="participants-{{roomid}}" class="room-participants" name="{{toclone}}roomsparticipants[{{roomid}}][]" multiple>
{{#courseparticipants}}
<option value="{{participantid}}" {{#selected}}selected{{/selected}}>{{participantemail}}</option>
<option value="{{participantid}}" {{#selected}}selected{{/selected}}>{{participantname}}</option>
{{/courseparticipants}}
</select>
</div>
Expand Down
4 changes: 2 additions & 2 deletions templates/breakoutrooms_rooms.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"courseparticipants": [
{
"participantid": "2",
"participantemail": "[email protected]",
"participantname": "John Doe",
"selected": true
}
],
Expand All @@ -52,7 +52,7 @@
"courseparticipants": [
{
"participantid": "2",
"participantemail": "[email protected]"
"participantname": "John Doe"
}
],
"coursegroups": [
Expand Down
Loading