Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display user first/last name in breakout room participants selector #562

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Display user first/last name in breakout room participants selector #562

merged 2 commits into from
Jan 19, 2024

Conversation

armccoy
Copy link
Contributor

@armccoy armccoy commented Jan 11, 2024

Fixes #551

jrchamp
jrchamp reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @armccoy! A couple suggestions that should resolve the automated checks and provide a better experience for some non-English users.

mod_form.php Outdated Show resolved Hide resolved
templates/breakoutrooms_rooms.mustache Outdated Show resolved Hide resolved
@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Jan 18, 2024
jrchamp
jrchamp approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @armccoy confirmed that the email change looks good and works well.

@jrchamp jrchamp merged commit 090eb08 into ncstate-delta:main Jan 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchamp jrchamp jrchamp approved these changes

Assignees

@armccoy armccoy

Labels
bug Fixes problems or reduces technical debt
Projects
No open projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in Breakout rooms setting, allow to show Human names
2 participants
@armccoy @jrchamp