Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Added service_slim #14

Closed
wants to merge 37 commits into from
Closed

Added service_slim #14

wants to merge 37 commits into from

Conversation

ncave
Copy link
Owner

@ncave ncave commented Feb 7, 2019

No description provided.

@ncave ncave force-pushed the service_slim branch 2 times, most recently from c761b9b to 3769f5c Compare February 22, 2019 12:11
@ncave
Copy link
Owner Author

ncave commented Feb 22, 2019

@alfonsogarciacaro Rebased to latest.

@ncave
Copy link
Owner Author

ncave commented Feb 22, 2019

@alfonsogarciacaro Rebased again to restore the original .net versions referenced, sorry about that.
Please note that recent changes in FCS changed all the namespaces (e.g. Microsoft.FSharp.* to FSharp.*).

@alfonsogarciacaro
Copy link

Yes, I noticed that as I had to remove the namespace change when copy and pasting Exprs.fs. No worries, now that my change is merged with your branch I just need to pull it, build the FCS dll and copy it to the Fable repo. For now I'm doing it manually but I can add a build target for that like "sync-fcs-fable".

Has there been any performance improvements with the rebase that make it worth to build it again and push a new Fable version, or can we just wait?

@ncave
Copy link
Owner Author

ncave commented Feb 22, 2019

@alfonsogarciacaro I don't know, I don't have a benchmark for the full FCS, only for FCS-Fable (which is still being rebased as it takes time. This one is much easier, as it practically doesn't touch FCS, just adds on top).
I guess you can wait for FCS version to officially change and be published to nuget, if you want.

@alfonsogarciacaro
Copy link

It's not so easy to go back to nuget FCS because Fable is calling now functions with different signatures :)

@ncave
Copy link
Owner Author

ncave commented Feb 23, 2019

@alfonsogarciacaro I didn't mean go back to the nuget version, I was saying you can wait until the official nuget version goes out and we rebase your fork again. But you don't have to wait, if you're ok with synch-ing repos more often.

@alfonsogarciacaro
Copy link

Ah, sorry. Misread your comment. I added the sync-fcs-repo build target so it should be easier from now on :)

@ncave
Copy link
Owner Author

ncave commented Feb 26, 2019

Rebased to latest (27.0.1).

KevinRansom and others added 17 commits March 2, 2019 10:17
* Fix build when proto is built

* Update dotnet cli, remove unused BuildToolsVersion.txt file
* warnings as error again

* update warnings as errors
* Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223

* make fsc.exe 32-bit for compat

* make fsc.exe 32-bit for compat

* improve diagnostics

* fix tests

* fix determinism
* process large expressions systematically

* add test cases

* update tests

* Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223

* make fsc.exe 32-bit for compat

* make fsc.exe 32-bit for compat

* fix build

* fix build

* ramp up max testing

* correct optimization of linear matches

* improve diagnostics

* fix tests

* tests only on .NET Framework for now

* fix determinism
* cleanup commas

* fix indentation

* Update IlxGen.fs

* apply formatting to additional files

* improve output of script

* improve output of script
* cleanup comments

* cleanup primes
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to:

Item.ImplicitOp(_, { contents = Some(TraitConstraintSln.FSMethSln(_, vref, _)) })
Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use.

An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025

Corresponding PR at FCS: fsharp#896
* cleanup semicolons (ugh)

* fix build

* a little more cleanup

* little bit more cleanup

* little bit more cleanup

* little bit more documentation

* little bit more docs

* whitespace cleanup and docs

* more whitespace and code formatting

* little bit more docs

* add diagnostics

* add diagnostics

* add diagnostics

* diagnostics

* diagnostics

* diagnostics

* add diagnostics and possible fix for tp smoke tests

* fix build

* fix build
* Set compiler libraries to netstandard2.0"

* Clean up #ifs

* Standardize on NETSTANDARD

* more
* spacing for commas and colons

* code review
@ncave
Copy link
Owner Author

ncave commented Mar 29, 2019

Rebased to latest (28.0.0).

@ncave ncave closed this Mar 29, 2019
@ncave ncave reopened this Mar 29, 2019
@ncave
Copy link
Owner Author

ncave commented May 20, 2019

@alfonsogarciacaro Closing this PR in favor of this one upstream.

@ncave ncave closed this May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants