-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
c761b9b
to
3769f5c
Compare
@alfonsogarciacaro Rebased to latest. |
@alfonsogarciacaro Rebased again to restore the original .net versions referenced, sorry about that. |
Yes, I noticed that as I had to remove the namespace change when copy and pasting Exprs.fs. No worries, now that my change is merged with your branch I just need to pull it, build the FCS dll and copy it to the Fable repo. For now I'm doing it manually but I can add a build target for that like "sync-fcs-fable". Has there been any performance improvements with the rebase that make it worth to build it again and push a new Fable version, or can we just wait? |
@alfonsogarciacaro I don't know, I don't have a benchmark for the full FCS, only for FCS-Fable (which is still being rebased as it takes time. This one is much easier, as it practically doesn't touch FCS, just adds on top). |
It's not so easy to go back to nuget FCS because Fable is calling now functions with different signatures :) |
@alfonsogarciacaro I didn't mean go back to the nuget version, I was saying you can wait until the official nuget version goes out and we rebase your fork again. But you don't have to wait, if you're ok with synch-ing repos more often. |
Ah, sorry. Misread your comment. I added the sync-fcs-repo build target so it should be easier from now on :) |
Rebased to latest (27.0.1). |
* Fix build when proto is built * Update dotnet cli, remove unused BuildToolsVersion.txt file
* Replace hats * Add spaces
* warnings as error again * update warnings as errors
* Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223 * make fsc.exe 32-bit for compat * make fsc.exe 32-bit for compat * improve diagnostics * fix tests * fix determinism
* process large expressions systematically * add test cases * update tests * Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223 * make fsc.exe 32-bit for compat * make fsc.exe 32-bit for compat * fix build * fix build * ramp up max testing * correct optimization of linear matches * improve diagnostics * fix tests * tests only on .NET Framework for now * fix determinism
* cleanup commas * fix indentation * Update IlxGen.fs * apply formatting to additional files * improve output of script * improve output of script
* cleanup comments * cleanup primes
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to: Item.ImplicitOp(_, { contents = Some(TraitConstraintSln.FSMethSln(_, vref, _)) }) Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use. An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025 Corresponding PR at FCS: fsharp#896
* cleanup semicolons (ugh) * fix build * a little more cleanup * little bit more cleanup * little bit more cleanup * little bit more documentation * little bit more docs * whitespace cleanup and docs * more whitespace and code formatting * little bit more docs * add diagnostics * add diagnostics * add diagnostics * diagnostics * diagnostics * diagnostics * add diagnostics and possible fix for tp smoke tests * fix build * fix build
* Set compiler libraries to netstandard2.0" * Clean up #ifs * Standardize on NETSTANDARD * more
* spacing for commas and colons * code review
…321.3 (#6366) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19171.3
* Re-enable ngen for desktop compilers * Go even earlier * Cooler mechanism
* update FCS dependencies * update FCS dependencies * fix up build * code review
…to-mar-02 Integrate vfsharp feb 25 to mar 29
Fixed typecheck logger Minor cleanup
Rebased to latest (28.0.0). |
@alfonsogarciacaro Closing this PR in favor of this one upstream. |
No description provided.