Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tooltip found for operators #1025

Closed
7sharp9 opened this issue Feb 18, 2019 · 6 comments
Closed

No tooltip found for operators #1025

7sharp9 opened this issue Feb 18, 2019 · 6 comments
Labels
bug language services Problems related to language services - FSAC or FCS

Comments

@7sharp9
Copy link
Contributor

7sharp9 commented Feb 18, 2019 •
edited by enricosada
Loading

The following operators result in no tooltips:

type NewSampleMessage =
    { mutable martId : int option
      mutable test_oneof : test_oneof option }
    static member JsonObjCodec =
        fun m t -> {martId = m; test_oneof = t}
        <!> jopt "martId"  (fun b -> b.martId)
//-------^
        <*> jopt "test_oneof" (fun a -> a.test_oneof)
//------ ^
Data={"FileName":"/Users/dave.thomas/Documents/GitHub/falanx/src/Falanx.Proto.Core/JsonCodec/Codec.fs","Line":510,"Column":10,"Filter":""}
[12:39:38 DEBUG] RES (180) <- {tooltip} in 17 ms: Kind={"info"}
Data="No tooltip information"
[12:39:38 DEBUG] REQ (181) -> {tooltip}, File = "~/src/Falanx.Proto.Core/JsonCodec/Codec.fs"
Data={"FileName":"/Users/dave.thomas/Documents/GitHub/falanx/src/Falanx.Proto.Core/JsonCodec/Codec.fs","Line":510,"Column":10,"Filter":""}
[12:39:38 DEBUG] RES (181) <- {tooltip} in 16 ms: Kind={"info"}
Data="No tooltip information"
@7sharp9
Copy link
Contributor Author

7sharp9 commented Feb 18, 2019

See here for repo: https://github.com/jet/falanx/blob/master/src/Falanx.Proto.Core/JsonCodec/Codec.fs#L504-L505

@Krzysztof-Cieslak Krzysztof-Cieslak added bug language services Problems related to language services - FSAC or FCS labels Feb 18, 2019
@7sharp9
Copy link
Contributor Author

7sharp9 commented Feb 25, 2019

@Krzysztof-Cieslak Reckon this is FCS or the island parser stuff?

@Krzysztof-Cieslak
Copy link
Member

TBF, no idea. Didn't have any time to look at it yet - last week I was at the conference, and now I have some work (🙄). Maybe later this week.

@7sharp9 7sharp9 mentioned this issue Mar 4, 2019
Closed
@7sharp9
Copy link
Contributor Author

7sharp9 commented Mar 4, 2019

Fixed by: fsharp/fsharp-compiler-docs#896

@7sharp9 7sharp9 mentioned this issue Mar 6, 2019
Merged
KevinRansom pushed a commit to dotnet/fsharp that referenced this issue Mar 9, 2019
@7sharp9 @KevinRansom
Add symbol creation for an operator with a constraint (#6307)
cfc9f37 
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to:

Item.ImplicitOp(_, { contents = Some(TraitConstraintSln.FSMethSln(_, vref, _)) })
Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use.

An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025

Corresponding PR at FCS: fsharp/fsharp-compiler-docs#896
baronfel pushed a commit to baronfel/FSharp.Compiler.Service that referenced this issue Mar 22, 2019
@7sharp9 @baronfel
Add symbol creation for an operator with a constraint (#6307)
24b5c2c 
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to:

Item.ImplicitOp(_, { contents = Some(TraitConstraintSln.FSMethSln(_, vref, _)) })
Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use.

An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025

Corresponding PR at FCS: fsharp#896
@Krzysztof-Cieslak
Copy link
Member

I guess this is fixed with FCS update.

@7sharp9
Copy link
Contributor Author

7sharp9 commented May 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug language services Problems related to language services - FSAC or FCS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@7sharp9 @Krzysztof-Cieslak