Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR implements changes required for ecgtools to update to the recently-released pydantic v2. Test are still failing because Intake-ESM also requires changes to update to pydantic v2 (see intake/intake-esm#619).
Unfortunately the
autodoc_pydantic
Sphinx extension does not support pydantic v2. Thus the docs build is also failing.It doesn't look like
autodoc_pydantic
will support pydantic v2 any time soon (see mansenfranzen/autodoc_pydantic#146) so the API section of the docs will potentially be poorly formatted for a while if we want to update ecgtools and Intake-ESM to use pydantic v2.Another option is to pin pydantic<2.0 in both ecgtools and Intake-ESM, but that has it's own (probably worse?) problems.
Related issue number
Closes #161
Checklist