-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for pydantic v2 #619
Conversation
for more information, see https://pre-commit.ci
Agh, the What to do?
|
for more information, see https://pre-commit.ci
This reverts commit 89cf5c2.
This reverts commit a6a2fcf.
I tried to disable the Instead, here's is a screenshot of the API docs for a pydantic object rendered without the |
Thanks so much @dougiesquire for the hard work here - I think this looks fine and we can proceed! |
Ready for review @mgrover1 Note, the docs build is still failing because of:
I suggest:
|
@dougiesquire You can now test the new autodoc_pydantic version supporting pydantic v2 via Any feedback is more than appreciated. The current autodoc_pydantic version |
Change Summary
This PR implements changes required for Intake-ESM to update to the recently-released pydantic v2. I'd appreciate someone taking a close look at this as I'm not a pydantic expert, especially v2.
Related issue number
Closes #617
Checklist