feat: ✨ Decommissioning Job #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iltin `indent` filter
chadell
commented
Dec 12, 2023
examples/backbone_design/designs/core_site/designs/0001_design.yaml.j2
Outdated
Show resolved
Hide resolved
Kircheneer
previously requested changes
Dec 13, 2023
nautobot_design_builder/jobs.py
Outdated
Comment on lines
27
to
32
| # TODO: how to make this more decoupled? | ||
| self.log_info( | ||
| f"Checking if the design instance {design_instance} can be decommissioned by external dependencies." | ||
| ) | ||
| self.log_success(f"No dependency issues found for {design_instance}.") | ||
| return True |
There was a problem hiding this comment.
I guess this is not the final implementation?
There was a problem hiding this comment.
no, the decoupling has to happen in this PR. any suggestion?
nautobot_design_builder/jobs.py
Outdated
Comment on lines
123
to
126
| content_type = ContentType.objects.get_for_model(DesignInstance) | ||
| design_instance.status = Status.objects.get( | ||
| content_types=content_type, name=DesignInstanceStatusChoices.DECOMMISSIONED | ||
| ) |
There was a problem hiding this comment.
Suggested change
| content_type = ContentType.objects.get_for_model(DesignInstance) | |
| design_instance.status = Status.objects.get( | |
| content_types=content_type, name=DesignInstanceStatusChoices.DECOMMISSIONED | |
| ) | |
| design_instance.status = Status.objects.get( | |
| name=DesignInstanceStatusChoices.DECOMMISSIONED | |
| ) |
This should be the same, shouldn't it?
There was a problem hiding this comment.
likely. I guess a Status can't have the same name and belong to a different content_type. will check
Co-authored-by: Leo Kirchner <[email protected]>
fix: Updates for OSRB documentation review
Updates pyproject.toml for 3.11
Kircheneer
reviewed
Dec 14, 2023
nautobot_design_builder/jobs.py
Outdated
Comment on lines
41
to
49
| try: | ||
| func = import_string(pre_decommission_hook) | ||
| except ImportError as error: | ||
| msg = ( | ||
| "There was an issue attempting to import the pre decommission hook " | ||
| f"{pre_decommission_hook}, this is expected with a local configuration issue and not related to" | ||
| " the Design Builder App, please contact your system admin for further details.\n" | ||
| ) | ||
| raise ValueError(msg + str(error)) from error |
There was a problem hiding this comment.
Instead of this approach - does it make sense/is it possible to instead just pass the callable directly? I.e. have the settings import it and then just use it here
There was a problem hiding this comment.
yes, it would make it easier. I will try it.
The `TransactionTestCase` actually has less test isolation than `TestCase` which caused the test designs to not actually get reverted between tests.
Moved the revertting code from the decommissioning job and into the JournalEntry model. Also added some tests to validate the code.
abates
reviewed
Dec 19, 2023
…llc/nautobot-plugin-design-builder into feature_delices_decom_job
abates
reviewed
Jan 3, 2024
abates
reviewed
Jan 3, 2024
abates
approved these changes
Jan 3, 2024
Kircheneer
reviewed
Jan 4, 2024
nautobot_design_builder/models.py
Outdated
Comment on lines
330
to
333
| ValidationError: _description_ | ||
|
|
||
| class JournalEntry(PrimaryModel): | ||
| Returns: | ||
| _type_: _description_ |
There was a problem hiding this comment.
I guess these would need to be fixed - I don't want to hold the MR up over this but before this gets into develop we will need to work with it anyway
This was referenced Jan 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
JournalandDesignInstance