Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates for OSRB documentation review #81

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Conversation

abates
Copy link
Contributor

@abates abates commented Oct 23, 2023

fixes #78

@abates abates linked an issue Oct 23, 2023 that may be closed by this pull request
11 tasks
| 1.0.X | 1.2.0 | 1.99.99 |
| 1.1.X | 1.4.0 | 1.99.99 |
| 1.2.X | 2.0.0 | 2.99.99 |
| 1.0.X | 1.6.0 | 2.0.X |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this plugin compatible with 1.x and 2.x at the same time??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will work with both major versions at the same time.

@@ -298,52 +298,6 @@ devices:

The path to the included template is relative to the directory where the design class is defined for the particular design job. Using the example layout defined above, this path would be `designs/design_files/templates/switch_template.yaml.j2`.

#### The `{%+ indent %}block{% endindent %}` statement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this relevant anymore?

chadell
chadell previously approved these changes Oct 31, 2023
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmsirbu cmsirbu mentioned this pull request Dec 11, 2023
11 tasks
@abates abates marked this pull request as ready for review December 11, 2023 19:42
@abates abates requested a review from mzbroch as a code owner December 11, 2023 19:43
Copy link
Contributor

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abates abates merged commit e96367c into develop Dec 13, 2023
14 checks passed
@abates abates deleted the osrb-docs-review branch December 13, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSRB Docs and Standards Review Feedback
3 participants