Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] When a block can not be compressed, mark it as such to avoid syncBlocks trying continously #5831

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

derekcollison
Copy link
Member

We had reports of disk spikes and memory pops queued off of syncBlocks, and looks like it was coming from blocks that were no longer compressible, but would load each time and go through the process.

Resolves: #5595

Signed-off-by: Derek Collison derek@nats.io

Verified

This commit was signed with the committer’s verified signature.
derekcollison Derek Collison
…ks constantly trying to compress on each iteration.

We had reports of disk spikes and memory pops queued off of syncBlocks, and looks like it was coming from blocks that were no longer compressable, but would load each time and go through the process.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner August 26, 2024 20:29
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 71f2728 into main Aug 26, 2024
5 checks passed
@derekcollison derekcollison deleted the no-compact branch August 26, 2024 21:44
wallyqs added a commit that referenced this pull request Aug 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Includes:

- #5825
- #5826
- #5821
- #5831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetStream: high disk IO, CPU usage, timeouts (Internal subscription took too long)
3 participants