Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry picks for v2.10.19 RC6 #5829

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Cherry picks for v2.10.19 RC6 #5829

merged 4 commits into from
Aug 27, 2024

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Aug 26, 2024 •
edited
Loading

MauriceVanVeen and others added 3 commits August 26, 2024 10:16
@MauriceVanVeen @wallyqs
Correct test name
c92d9c1 
Signed-off-by: Maurice van Veen <[email protected]>
@derekcollison @neilalexander @wallyqs
[FIXED] New staticcheck fixes (#5826)
208fdcd 
@neilalexander I do believe this uncovered two off by one conditions in
node48 under stree. Could you take a look, kept that change separate.

---------

Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Neil Twigg <[email protected]>
Co-authored-by: Neil Twigg <[email protected]>
@wallyqs @derekcollison
Do not bump clfs on seq mismatch when before stream LastSeq (#5821)
5ee2bd4 
Sometimes during a stream catchup after a restart, when applying entries
the clfs could have been bumped due to msg not found errors from likely
deleted messages, causing a stream replica to remain out of sync.

Fixes #5205

---------

Signed-off-by: Waldemar Quevedo <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
Co-authored-by: Derek Collison <[email protected]>
@wallyqs wallyqs requested a review from a team as a code owner August 26, 2024 17:20
@wallyqs wallyqs changed the base branch from main to release/v2.10.19 August 26, 2024 17:20
@derekcollison @wallyqs
When a block can not be compressed, mark it as such to avoid syncBloc…
0b5e1ec 
…ks constantly trying to compress on each iteration.

We had reports of disk spikes and memory pops queued off of syncBlocks, and looks like it was coming from blocks that were no longer compressable, but would load each time and go through the process.

Signed-off-by: Derek Collison <[email protected]>
derekcollison
derekcollison approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit e5e2d14 into release/v2.10.19 Aug 27, 2024
5 checks passed
@wallyqs wallyqs deleted the downstream/v2.10.19 branch August 27, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wallyqs @derekcollison @MauriceVanVeen