Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Make sure to hold lock for duration of truncate #5279

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[FIXED] Make sure to hold lock for duration of truncate #5279

merged 1 commit into from
Apr 4, 2024

Conversation

derekcollison
Copy link
Member

Make sure to hold lock for duration of truncate, was calling slotInfo unprotected.

Signed-off-by: Derek Collison [email protected]

@derekcollison derekcollison requested a review from a team as a code owner April 4, 2024 20:48
neilalexander
neilalexander approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit fcff483 into main Apr 4, 2024
3 of 4 checks passed
@derekcollison derekcollison deleted the fs-truncate-locking branch April 4, 2024 20:50
@neilalexander neilalexander mentioned this pull request Apr 4, 2024
Merged
derekcollison added a commit that referenced this pull request Apr 4, 2024
@derekcollison
Cherry-pick PRs for v2.10.14-RC.2 (#5278)
8cafe5b 
Cherry-pick the following PRs into the v2.10.14 release branch:

* #5237
* #5238
* #5242
* #5208
* #5244
* #5248
* #5246
* #5112
* #5247
* #5256
* #5258
* #5264
* #5266
* #5267
* #5265
* #5271
* #5270
* #5272
* #5276
* #5274
* #5275
* #5277
* #5279

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekcollison @neilalexander