Speed-up some tests and fixing some lint reports. #5258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were executed against the parent commit of when they were added to make sure that the tuning is not affecting the reproducibility of the test. Note that some of the tests were sometimes not detecting the bug, even when running with `-count=xxx`, so in that case, it is difficult to know if the tuning would prevent detection if the bug were to be reintroduced. The FileStore and MsgTrace tests were also added as a matrix run in Travis/GA. Signed-off-by: Ivan Kozlovic <[email protected]>
Signed-off-by: Ivan Kozlovic <[email protected]>
|
@derekcollison I started looking at some outlier in term of duration and manually tuned some of them (started with TestNoRace ones). I could not really make the overall duration fall that much. I have separated FileStore and MsgTrace tests as separate runs in Travis, not sure if this is something that you will agree with. If you do, there maybe more to do to bring some of the matrix runs down to 5/6 minutes as opposed to 9+ as they are now. |
Signed-off-by: Ivan Kozlovic <[email protected]>
Excluded the files that were auto-generated (with a do not edit comment). Signed-off-by: Ivan Kozlovic <[email protected]>
|
Should I do normal merge or squash merge? |
|
@derekcollison I would do simple merge (I would want the interface{}->any stay as its own commit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were executed against the parent commit of when they were
added to make sure that the tuning is not affecting the reproducibility
of the test. Note that some of the tests were sometimes not detecting
the bug, even when running with
-count=xxx, so in that case, itis difficult to know if the tuning would prevent detection if the
bug were to be reintroduced.
The FileStore and MsgTrace tests were also added as a matrix run
in Travis/GA.
Signed-off-by: Ivan Kozlovic [email protected]