Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve validation message when bounding boxes don't intersect #502 #1376

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

emlys
Copy link
Member

@emlys emlys commented Aug 21, 2023

Description

Fixes #502
I took a stab at rewording the validation message based off the conversation in the issue. Let me know what you think!

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the affected models' UIs (if relevant)

@emlys emlys requested a review from dcdenu4 August 21, 2023 18:12
@emlys emlys marked this pull request as ready for review August 21, 2023 18:13
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emlys , looks like a better message to me!

@dcdenu4 dcdenu4 merged commit b6a0c70 into natcap:main Aug 23, 2023
19 checks passed
@emlys emlys deleted the task/502 branch October 3, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve language in spatial overlap validation messages
2 participants