Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language in spatial overlap validation messages #502

Closed
davemfish opened this issue Feb 25, 2021 · 3 comments · Fixed by #1376
Closed

Improve language in spatial overlap validation messages #502

davemfish opened this issue Feb 25, 2021 · 3 comments · Fixed by #1376
Assignees
Labels
enhancement New feature or request in progress This issue is actively being worked on
Milestone

Comments

@davemfish
Copy link
Contributor

davemfish commented Feb 25, 2021

@newtpatrol suggests the current language isn't well-understood by users and we could do better:

"Bounding box does not intersect at least one other [...]", and as we've seen on the forum, a lot of people don't understand what that means. Could it be changed to something like "Not all of the spatial layers overlap each other. Do they all have the same projected coordinate system?"

I agree the first half of this proposed language is clearer. But not all models require the "same projected coordinate system", so we may not want to go that far.

Often the problem is an incorrectly assigned coordinate system - meaning the user-defined CRS does not match the actual CRS of the coordinates. This is a notoriously tricky thing for GIS beginners and would be pretty challenging to instruct people how to fix this in a sentence or two.

@davemfish
Copy link
Contributor Author

For this particular validation message, the workbench does some parsing & formatting to improve readability, so it will be important to make sure that still works well. There are workbench tests covering that formatting which will probably fail if the language is changed. So that will be a good reminder.

@davemfish davemfish added enhancement New feature or request question Further information is requested labels Feb 25, 2021
@dcdenu4
Copy link
Member

dcdenu4 commented Feb 25, 2021

I agree this is a tricky one. I wonder if something generic up front like Stacie has:

Not all of the spatial layers overlap each other. Please check projections in a GIS tool as well as the requirements for the model.

And then also dump some helpful debugging info for developer troubleshooting? If we wanted to be fancy it could even be a Details dropdown that's hidden?

Bounding box does not intersect at least one other [...]

@davemfish davemfish removed the question Further information is requested label May 4, 2023
@davemfish
Copy link
Contributor Author

Let's at least take action on this part of the suggestion:

"Bounding box does not intersect at least one other [...]", and as we've seen on the forum, a lot of people don't understand what that means. Could it be changed to something like "Not all of the spatial layers overlap each other."

@davemfish davemfish added this to the 3.13.1 milestone May 4, 2023
@emlys emlys self-assigned this Aug 18, 2023
@emlys emlys added the in progress This issue is actively being worked on label Aug 18, 2023
emlys added a commit to emlys/invest that referenced this issue Aug 21, 2023
emlys added a commit to emlys/invest that referenced this issue Aug 22, 2023
dcdenu4 added a commit that referenced this issue Aug 23, 2023
improve validation message when bounding boxes don't intersect #502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress This issue is actively being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants