Fix incorrect path taken when rescue nested inside a rescue/else #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seven1m
added a commit
that referenced
this pull request
Sep 4, 2023
seven1m
added a commit
that referenced
this pull request
Sep 4, 2023
seven1m
changed the title
Turns out this bug can be triggered without a LocalJumpError scenario, just by nesting a rescue/else that is unused.
seven1m
force-pushed
the
rescue-else-break-error
branch
from
f525281 to
cd5975e
Compare
seven1m
changed the title
seven1m
added a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compiler bug. There is something odd going on with the LocalJumpError caused by a return inside a block.When the return is not followed,GlobalEnv::rescuedgets set tofalse, and that causes the outerrescue/elseto think that theelseblock should run.This makes me think that we either cannot use a global to trackrescued, or that we have to put it back when checking for LocalJumpError.Turns out this can be triggered much more simply, and the above
LocalJumpErrorexplanation is but a symptom of this simpler problem. You cannot nest arescueinside arescue/elseand get the correct result reliably. 🤦♂️