Refactor code for exception and raise

natalie-lang · Sep 4, 2023 · cd5975e · cd5975e
1 parent a9bea86
commit cd5975e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/env.cpp b/src/env.cpp
@@ -264,11 +264,9 @@ Value Env::exception_object() {
 
 ExceptionObject *Env::exception() {
     auto e = this;
-    for (;;) {
+    while (e) {
         if (e->m_exception)
             return e->m_exception;
-        if (!e->m_caller)
-            break;
         e = e->m_caller;
     }
     return nullptr;

diff --git a/src/kernel_module.cpp b/src/kernel_module.cpp
@@ -473,9 +473,8 @@ Value KernelModule::puts(Env *env, Args args) {
 
 Value KernelModule::raise(Env *env, Value klass, Value message) {
     if (!klass) {
-        if (env->exception())
-            klass = env->exception();
-        else {
+        klass = env->exception();
+        if (!klass) {
             klass = find_top_level_const(env, "RuntimeError"_s);
             message = new StringObject { "" };
         }