Avoid loading the entire log files into memory

src/fprime_gds/common/files/downlinker.py

@@ -114,7 +114,6 @@ def handle_data(self, data):
         """
         # Initialize all relevant DATA packet attributes into variables from file_data
         offset = data.offset
-        data_bytes = data.dataVar
         if self.state != FileStates.RUNNING:
             LOGGER.warning("Received unexpected data packet for offset: %d", offset)
         else:
@@ -124,6 +123,7 @@ def handle_data(self, data):
                     self.sequence,
                     data.seqID,
                 )
+            data_bytes = data.dataVar
             # Write the data information to the file
             self.active.write(data_bytes, offset)
             self.active.seek = offset + len(data_bytes)

src/fprime_gds/common/loaders/dict_loader.py

@@ -112,4 +112,4 @@ def construct_dicts(self, path):
             for both should be data_template classes. This base class only
             returns empty dictionaries.
         """
-        return dict(), dict(), ("unknown", "unknown")
+        return {}, {}, ("unknown", "unknown")

src/fprime_gds/executables/run_deployment.py

@@ -89,7 +89,7 @@ def launch_process(cmd, logfile=None, name=None, env=None, launch_time=5):
         try:
             if logfile is not None:
                 with open(logfile) as file_handle:
-                    for line in file_handle.readlines():
+                    for line in file_handle:
                         print(f"    [LOG] {line.strip()}", file=sys.stderr)
         except Exception:
             pass

src/fprime_gds/executables/tcpserver.py

@@ -221,9 +221,7 @@ def recv(self, l):
             except OSError as err:
                 if err.errno == errno.ECONNRESET:
                     print(
-                        "Socket error "
-                        + str(err.errno)
-                        + " (Connection reset by peer) occurred on recv()."
+                        f"Socket error {str(err.errno)} (Connection reset by peer) occurred on recv()."
                     )
                 else:
                     print(f"Socket error {str(err.errno)} occurred on recv().")
@@ -237,11 +235,7 @@ def readHeader(self):
         header = self.recv(5)
 
         if len(header) == 0:
-            print(
-                "Header information is empty, client "
-                + self.name.decode(DATA_ENCODING)
-                + " exiting."
-            )
+            print(f"Header information is empty, client {self.name.decode(DATA_ENCODING)} exiting.")
             return header
         if header == b"List\n":
             return b"List"
@@ -260,9 +254,7 @@ def readData(self, header):
         FSW receives commands of various lengths.
         """
         data = b""
-        if header == b"List":
-            return b""
-        elif header == b"Quit":
+        if header in [b"List", b"Quit"]:
             return b""
         dst = header.split(b" ")[1].strip(b" ")
         if dst == b"FSW":