Avoid loading the entire log files into memory #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR aims to use the built-in file iterator rather than calling
readlines()
to read the log files.PS: I've fixed some other small issues that I felt didn't deserve to be put in a dedicated PR.
Rationale
It is preferable to do it this way because the
file
object returned by Python when opening a file is a lazy iterator over the lines in that file.This means that it is not necessary to use
readlines()
to loop through the file. Using built-in iteration is shorter and does not load the entire file into memory with a list object, asreadlines()
does, which can be more efficient.Testing/Review Recommendations
Ref1
Ref2
Future Work
None