-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #762, scrub of all CFE UT stub functions #763
Merged
astrogeco
merged 9 commits into
nasa:integration-candidate
from
jphickey:fix-762-ut-stub-scrub
Jul 2, 2020
Merged
Fix #762, scrub of all CFE UT stub functions #763
astrogeco
merged 9 commits into
nasa:integration-candidate
from
jphickey:fix-762-ut-stub-scrub
Jul 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate: 2020-05-27
Integration Candidate: 2020-06-10
Fx nasa#730, Adds null to FILEDEFs
Integration Candidate: 2020-06-17
Scrubs all CFE unit test functions to ensure that: 1. All functions in the CFE public API have a stub function implemented 2. All parameters to the stub function are registered in the context object, so the values will be available to hook functions. 3. The names of all parameters match the prototype/documentation, so hook functions that use name-based argument value retrieval will work.
jphickey
added
the
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
label
Jun 26, 2020
skliper
approved these changes
Jun 29, 2020
CCB 2020-07-01: APPROVED |
astrogeco
added
CCB:FastTrack
and removed
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
labels
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Scrubs all CFE unit test functions to ensure that:
so the values will be available to hook functions.
functions that use name-based argument value retrieval will work.
Fix #762
Fix #702
Testing performed
Build and run all CFE unit tests
Sanity check on CFE execution (but this doesn't change any FSW code).
Expected behavior changes
No impact to current behavior - except it does change the internal names of some stub arguments to match prototype.
Note this only changes UT stubs.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.