Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub all CFE UT stub functions #762

Closed
jphickey opened this issue Jun 25, 2020 · 0 comments · Fixed by #763 or #765
Closed

Scrub all CFE UT stub functions #762

jphickey opened this issue Jun 25, 2020 · 0 comments · Fixed by #763 or #765
Assignees
@jphickey
Labels
enhancement
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The CFE stub functions remain incomplete and inconsistent. They need a scrub to bring everything up to the level it should be.

Describe the solution you'd like

  • All functions prototyped in the CFE public API headers (the fsw/cfe-core/src/inc dir) should also have a stub defined.
  • All arguments should be registered in the context so the complete context is available within UT hook functions.
  • The argument names should always match the prototype.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jun 25, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Jun 26, 2020
@jphickey
Fix nasa#762, scrub of all CFE UT stub functions
79f1c38 
Scrubs all CFE unit test functions to ensure that:

1. All functions in the CFE public API have a stub function implemented
2. All parameters to the stub function are registered in the context object,
   so the values will be available to hook functions.
3. The names of all parameters match the prototype/documentation, so hook
   functions that use name-based argument value retrieval will work.
This was referenced Jun 26, 2020
Merged
Closed
astrogeco added a commit that referenced this issue Jul 2, 2020
@astrogeco
Merge pull request #763 from jphickey/fix-762-ut-stub-scrub
4f9c331 
Fix #762, scrub of all CFE UT stub functions
@astrogeco astrogeco mentioned this issue Jul 26, 2020
Merged
astrogeco pushed a commit that referenced this issue Jul 26, 2020
@jphickey
Fix #762, scrub of all CFE UT stub functions
43bbb74 
Scrubs all CFE unit test functions to ensure that:

1. All functions in the CFE public API have a stub function implemented
2. All parameters to the stub function are registered in the context object,
   so the values will be available to hook functions.
3. The names of all parameters match the prototype/documentation, so hook
   functions that use name-based argument value retrieval will work.
@astrogeco astrogeco added this to the 6.8.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Bootes
2 participants
@jphickey @astrogeco